File comparator window position

Discussion of bugs and problems found in Altap Salamander. In your reports, please be as descriptive as possible, and report one incident per report. Do not post crash reports here, send us the generated bug report by email instead, please.
User avatar
mdruiter
Posts: 263
Joined: 22 Feb 2006, 15:33
Location: Amsterdam, The Netherlands
Contact:

File comparator window position

Post by mdruiter »

When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
[attachment=0]Lower part of the screen.png[/attachment]
Attachments
The lower part of my screen
The lower part of my screen
Lower part of the screen.png (33.68 KiB) Viewed 8188 times
Groente, Michel.
Jan Patera
Plugin Developer
Plugin Developer
Posts: 707
Joined: 08 Dec 2005, 14:33
Location: Prague, Czech Republic
Contact:

Re: File comparator window position

Post by Jan Patera »

mdruiter wrote:When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
Lower part of the screen.png
Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.
User avatar
Ether
Posts: 1471
Joined: 10 May 2007, 16:08
Location: Czech Republic
Contact:

Re: File comparator window position

Post by Ether »

Jan Patera wrote:Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.
It looks like incompatible functions' return values and parameters.
Ελληνικά rulez.
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: File comparator window position

Post by Jan Rysavy »

mdruiter, what about internal text viewer (F3 on text file), does it open exactly above Salamander?
User avatar
mdruiter
Posts: 263
Joined: 22 Feb 2006, 15:33
Location: Amsterdam, The Netherlands
Contact:

Re: File comparator window position

Post by mdruiter »

The internal text viewer, PictView and Eroiica Viewer all position correctly: exactly above Salamander.
Groente, Michel.
User avatar
zarevak
Plugin Developer
Plugin Developer
Posts: 789
Joined: 04 Feb 2006, 16:49
Location: Prague, Czech Republic

Re: File comparator window position

Post by zarevak »

It seems to be similar problem as was in internal beta of DiskMap plugin (v0.5.25) - by using GetWindowPlacement() (which uses workspace coordinates) instead of GetWindowRect() which uses screen coordinates, which are usable by CreateWindow() taht uses screen coordinates as well.
Jan Patera
Plugin Developer
Plugin Developer
Posts: 707
Joined: 08 Dec 2005, 14:33
Location: Prague, Czech Republic
Contact:

Re: File comparator window position

Post by Jan Patera »

Jan Patera wrote:
mdruiter wrote:When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
Lower part of the screen.png
Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.
The problem has been fixed for the next version of Salamander (2.52).
User avatar
mdruiter
Posts: 263
Joined: 22 Feb 2006, 15:33
Location: Amsterdam, The Netherlands
Contact:

Re: File comparator window position

Post by mdruiter »

Confirmed!
Groente, Michel.
Post Reply