Page 1 of 1

File comparator window position

Posted: 25 Aug 2009, 12:43
by mdruiter
When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
[attachment=0]Lower part of the screen.png[/attachment]

Re: File comparator window position

Posted: 25 Aug 2009, 13:13
by Jan Patera
mdruiter wrote:When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
Lower part of the screen.png
Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.

Re: File comparator window position

Posted: 25 Aug 2009, 15:47
by Ether
Jan Patera wrote:Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.
It looks like incompatible functions' return values and parameters.

Re: File comparator window position

Posted: 25 Aug 2009, 15:56
by Jan Rysavy
mdruiter, what about internal text viewer (F3 on text file), does it open exactly above Salamander?

Re: File comparator window position

Posted: 25 Aug 2009, 22:06
by mdruiter
The internal text viewer, PictView and Eroiica Viewer all position correctly: exactly above Salamander.

Re: File comparator window position

Posted: 25 Aug 2009, 23:09
by zarevak
It seems to be similar problem as was in internal beta of DiskMap plugin (v0.5.25) - by using GetWindowPlacement() (which uses workspace coordinates) instead of GetWindowRect() which uses screen coordinates, which are usable by CreateWindow() taht uses screen coordinates as well.

Re: File comparator window position

Posted: 26 Aug 2009, 21:33
by Jan Patera
Jan Patera wrote:
mdruiter wrote:When I compare two files, the File comparator (plugin) window gets positioned too far to the left, under my (vertical!) Windows button bar:
Lower part of the screen.png
Interesting. It appears that FileComp does not honor non-auto-hiding TaskBar (when on top or left side) when it positions its window.
The problem has been fixed for the next version of Salamander (2.52).

Re: File comparator window position

Posted: 02 Sep 2009, 10:53
by mdruiter
Confirmed!