Page 1 of 2

Missing Tortoise SVN overlay icons

Posted: 27 May 2008, 18:54
by voidcoder
Hi there,

apparently, there is something wrong with the shell icons in the
recent AS 2.51. Quite often AS will show some icon discrepancy
compared to explorer and other shells. It is not bothering me in
the most of cases but the Tortoise SVN subversion icons, where
file/folder icons are dynamically changing depending on the SVN
status. The SVN icons disappear in AS leaving standard windows
icons (even though Explorer and Co. are still displaying SVN icons).

Sometimes re-opening AS fixes the problem, sometimes not and
I have to go back to the f. windows explorer to do some SVN
work :( Can this be fixed pls?

Shows on both XP SP2 and SP3, not sure about Vista.

Posted: 27 May 2008, 19:51
by Jan Rysavy
Does it apply to both icons and icon overlays (used by Tortoise SVN)?

Could you please post examples (Salamander beside Explorer) where the problem will be visible?
(it is possible to attach .PNG file to the post)

Icons issue (screenshot)

Posted: 28 May 2008, 10:37
by voidcoder
Sure, here is the screenshot. Strange though, the icons sometimes appear
back when re-opening SA.

Icons issue

Posted: 28 May 2008, 10:44
by voidcoder
The issue applies to the overlays only, not the icons themselves.

Posted: 28 May 2008, 14:25
by Jan Rysavy
Could you please try to install TortoiseSVN 1.5.0-RC2?

From your first post it looks like you have problems with other icon overlays than Tortoise SVN?

Please check also your Salamander configuration, see first attached screenshot. These options must be turned on.

Also check the Tortoise SVN settings (the second screenshot), the "Show overlays only in explorer" must be turned off.

Icon overlays

Posted: 28 May 2008, 21:27
by voidcoder
Yep, the overlays are enabled in AS and allowed in all apps in Tortoise.
The only thing is that they are constantly on in explorer but quite often
disappear in AS. Sometimes it is enough to just re-open AS, sometimes
even enough to browse through other disks/folders and then come back
to the same directory and the overlays are there again. I can't find any
reliable dependency or exact action causing the overlays to disappear.

Posted: 29 May 2008, 07:59
by Jan Rysavy
Thank you for all information.

Could you upgrade to latest TSVN 1.5.0 Release Candidate?
There are known problems in 1.4.8 branch that are fixed in 1.5.0.

Edit: I still don't get this:
voidcoder wrote:Quite often AS will show some icon discrepancy
compared to explorer and other shells. It is not bothering me in
the most of cases but the Tortoise SVN subversion icons, where
file/folder icons are dynamically changing depending on the SVN
status.
Do you experience problems another than TSVN related?

Icon overlays

Posted: 30 May 2008, 15:04
by voidcoder
Hi Jan,
Edit: I still don't get this:

voidcoder wrote:
Quite often AS will show some icon discrepancy
compared to explorer and other shells. It is not bothering me in
the most of cases but the Tortoise SVN subversion icons, where
file/folder icons are dynamically changing depending on the SVN
status.
Sorry, I was not clear. I'm talking about the overlay discrepancy,
not the icons. It is only overlays which are suddenly stopping to
work in AS but still show in explorer.

[/quote]

Posted: 30 May 2008, 22:10
by Jan Rysavy
And what about TSVN 1.5.0 RC?

Overlays

Posted: 03 Jul 2008, 11:56
by Guest
Hi Jan,

Any update on this? The icon overlays keep disappearing in SS 2.51,
doesn't matter what TSVN version you are using. I've tried 1.5.0
RC, RC1 and now 1.5.0 release and the problem is always there.
I wouldn't blame TSVN as the problem doesn't show in Explorer
or other shells (e.g. Total Commander) on the same exactly machine
running side by side with SS. Re-opening SS gets the overlays back
but quite often going one level up and then returning back to the same
folder removes overlays again.

Please, can you look into this! It is so horrible switching every time to
a different program just to check SVN status for some files.
Jan Rysavy wrote:And what about TSVN 1.5.0 RC?

Posted: 03 Jul 2008, 12:34
by Jan Rysavy
I did update subject of this thread. I will install TSVN 1.5.0 and look into this.

Does anybody else experience this problem?

Posted: 08 Aug 2008, 10:32
by deice
I'm also experiencing this problem (Vista 32-bit, AS 2.51, TSVN 1.5.2.13595)

Explorer views show Overlay icons okay for TortoiseSVN, but in Salamander the overlays occasionally disappear. Often a simple refresh (ctrl-R) helps, but not always. There is often also other discrepancies with the overlays, such as a folder showing the green ok icon instead of the modified icon (red exclamation) even though there are changes in the folder and the red exclamation mark is visible in explorer. I haven't found a reliable way to refresh this discrepancy.

Any updates on this issue?

Posted: 08 Aug 2008, 10:34
by Jan Rysavy
No progress, I'm sorry. We are testing TSVN on several computers, but cannot reproduce the problem.

Posted: 08 Aug 2008, 10:55
by cincura.net
This is TSVN "issue". First, when you do some "update" in folder (i.e. revert file) the state for this folder is for a while unknown, so the icons are not shown (this is coupled to the AS's panel refresh, because of change in directory). When you refresh the panel manually, the state is back OK, and icons are shown. Second problem has similar background. If you try to step in and out the folder, the overlay will be OK, it's something like force refresh (more or less you can set this in TSVN configuration). And smiliar to nested folders.

I think it's not AS fault, it's how TSVN works.

Posted: 08 Aug 2008, 11:34
by deice
I did some tests on this and it seems to be related to how TortoiseSVN updates the overlays. If you edit a file outside Salamander (eg. in an IDE) and then browse the folders in Salamander, the icon overlay won't update to "modified". When you open the folder in explorer the file changes to modified immediately in explorer, but not in Salamander (see attached screenshot). After you've browsed to the folder in explorer and seen the updated icon there, pressing ctrl-R in Salamander causes the overlay to update to "modified" state.

I also noticed theres a small delay when browsing in explorer before the overlays appear (eg. when scrolling down). I'm guess TSVN is updating the overlays on the fly with some kind of hook, and for some reason Salamander is not firing those hooks, and hence no updates. Unfortunately I don't have time now to browse the TortoiseSVN source code to look at how TortoiseSVN hooks into explorer right now.

Thanks for taking the time to look at this, it's quite an annoyance when developing large software projects.