7zipsfx and files >2GB

Discussion of bugs and problems found in Altap Salamander. In your reports, please be as descriptive as possible, and report one incident per report. Do not post crash reports here, send us the generated bug report by email instead, please.
enzo

7zipsfx and files >2GB

Post by enzo »

Thank you for your 7zipsfx.
It's very good that you added the file attributes and file dates support to 7ZIP's ANSI-C decoder.
However, your implementation still cannot extract files that a bigger than 2GB from 7zip archives. In file 7zExtract.c we can see this:

*outBuffer = (Byte *)allocMain->Alloc((size_t)unPackSize);
*outBufferSize = (size_t)unPackSize;

so decompressor tries to allocate entire uncompressed file size. If a file size is bigger than 2GB, this will always fail on x86. Although, considering a file size is, say, 1.5GB, it is not a good practice to decompress entire file in memory either. Even if such a huge memory allocation succeeds, it will lead to much swapping and slowing down.
Can this be fixed? It would be nice to do decompression in smaller chunks, calling SzDecode in a loop, and writing decompressed data chunk to a file after each iteration (for example via a callback function).
Can you implement this?
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Post by Jan Rysavy »

Unfortunately, we don't plan to work on Zip2Sfx now. We are using it solely for our own installer and it works well there. I'm sorry for bad news.
therube
Posts: 681
Joined: 14 Dec 2006, 06:22

Post by therube »

Are we talking about different archivers here?
7zipsfx (presumably meaning Sfx7Zip) & Zip2Sfx?
WinXP Pro SP3 or Win7 x86 | SS 2.54
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Post by Jan Rysavy »

I'm sorry for my typo. I meant the Sfx7Zip.

Zip2Sfx is part of Altap Self-Extractor and will be supported.
Post Reply