Focused field in filter dialog

antp · Post by **antp** » 16 Apr 2007, 10:24

Hello,
I noticed an "annoying" change in RC3: when filter is enabled, the first focused field is the radio button.
In RC2 it was the text box, allowing to directly type the filter after having pressed Ctrl+F12.
Or maybe that this was previously considered as a "bug"?

Post by **Petr Solin** » 16 Apr 2007, 10:50

It was fix for another bug.

Situation: you are not using filter and when you open this dialog, editbox with mask is focused.

Well, I'll patch it to focus the editbox only if filter is used.

SvA · Post by **SvA** » 16 Apr 2007, 13:17

Petr, I don't understand why you'd call this a bug. If no filter is active and you call up this dialog, the most obvious thing you will want to do is to set the filter.

You might consider to change the radio control to 'Use filter' by default in this situation and, in any case activate it on any key press or mouse click which does not move focus away from the edit box (i.e. any cursor moves or a click into the input field (for mouse clicks even when it transfers focus to the field, key presses only if it had it before already).

antp · Post by **antp** » 16 Apr 2007, 16:27

That's what I was also going to say, so I agree: in all cases that field is the best to focus. The behaviour that you describe is what was already in previous version if I remember well.

Post by **Petr Solin** » 17 Apr 2007, 10:26

I will not auto-focus the Use filter radiobox because if I did it you would not be able to find out if filter is used or not. Do not forget that filter symbol in Directory Line is displayed only when some files were hidden (filtered).

antp · Post by **antp** » 17 Apr 2007, 11:48

The question was about the text field, not the radio. In RC2 it opened like this:

(edit: well, I should have selected the other radio button, but you see what I mean, the field contents was focused)
In RC3 it opens like this:

Post by **Petr Solin** » 17 Apr 2007, 12:14

OK, I'll correct my sentense: I will not auto-select the Use filter radiobox and auto-focus following edit-box because if I did it you would not be able to find out if filter is used or not.

But if you are using filter, focus will be placed in edit-box.

antp · Post by **antp** » 17 Apr 2007, 20:33

Petr Solin wrote: But if you are using filter, focus will be placed in edit-box.

OK, thanks