Bad FileName insertion (on Ctrl+Enter)

We welcome any suggestions for new features or improvements in Altap Salamander. Please post one suggestion per report.

Do you want to quote names-containing-spaces on Ctrl+[,],Enter,Space?

Yes
7
32%
No
15
68%
 
Total votes: 22

User avatar
crystalidea
Posts: 205
Joined: 09 Dec 2005, 15:13
Contact:

Bad FileName insertion (on Ctrl+Enter)

Post by crystalidea »

When I insert the seleted filename (and it contains spaces) pressing CtrlEnter, SS don't quote it. Really bad!

Moderator: this is not a bug, moved to the Feature Requests. Poll opened.
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Post by Jan Rysavy »

I don't like this idea. If I need to bring the path from inactive panel + file name from the active panel, I will get

"C:\long dir name\""file name.txt"

instead of current

C:\long dir name\file name.txt

So I would rather insert the quotes myself.
User avatar
crystalidea
Posts: 205
Joined: 09 Dec 2005, 15:13
Contact:

Post by crystalidea »

Not only you use SS, isn't it? :wink:
User avatar
jis
Posts: 451
Joined: 27 Jan 2006, 23:14
Location: Prague, Czech Republic

Post by jis »

XPiS wrote:Not only you use SS, isn't it? :wink:
But, did you see the results of voting?
Altap Salamander fan since 1998
Jan Patera
Plugin Developer
Plugin Developer
Posts: 707
Joined: 08 Dec 2005, 14:33
Location: Prague, Czech Republic
Contact:

Post by Jan Patera »

Jan Rysavy wrote:I don't like this idea. If I need to bring the path from inactive panel + file name from the active panel, I will get

"C:\long dir name""file name.txt"

instead of current

C:\long dir name\file name.txt

So I would rather insert the quotes myself.
IMHO the overhead of removing extra quotes in your example is gonna happen much rarely than the overhead of adding quites where needed - in most cases it is enough to provide just path-less filename.
User avatar
Ether
Posts: 1471
Joined: 10 May 2007, 16:08
Location: Czech Republic
Contact:

Post by Ether »

Jan Patera wrote:IMHO the overhead of removing extra quotes in your example is gonna happen much rarely than the overhead of adding quites where needed
I agree.

@ALTAP] How about an option in configuration? (I do know how much you like new configuration options.)

@everybody] What other disadvantages of automatic quoting you know of? I mean, why don't you want auto-quoting?
Ελληνικά rulez.
User avatar
SvA
Posts: 486
Joined: 29 Mar 2006, 02:41
Location: DE

Post by SvA »

Have you ever noticed how Microsoft does filename expansion on the command prompt (using TAB or whatever shortcut key you configured)? Quote marks are added and removed as needed, E.g. "C:\Program Files"\+TAB gives "C:\Program Files\Altap" (note the backslash after the termination quote signe before expansion).
Granted, it uses only existing file and folder names, but even without that help it should be fairly easy to build a valid file system object name from the fragments given without surprising or annoying the user.

And I'd like to mention here, as is requested in other places already, than this type of command completion as well as the type used by the run dialog or explorer's address bar was a great enhancement for Salamanders command line as well as various other dialogs.
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Post by Jan Rysavy »

SvA wrote:Have you ever noticed how Microsoft does filename expansion on the command prompt (using TAB or whatever shortcut key you configured)? Quote marks are added and removed as needed, E.g. "C:\Program Files"\+TAB gives "C:\Program Files\Altap" (note the backslash after the termination quote signe before expansion).
It looks good! I didn't know that.
Post Reply