Missing Tortoise SVN overlay icons

Post by **Jan Rysavy** » 08 Aug 2008, 12:44

Thank you for detailed information, we will look into it and let you know!

Post by **Jan Rysavy** » 08 Aug 2008, 17:03

We are able to reproduce this problem, even in Windows Explorer. Please look at attached screenshots. Windows Vista Ultimate x64 EN.
TortoiseSVN 1.5.2, Build 13595 - 64 Bit , 2008/07/31 17:04:57.

How to reproduce it: change build.txt using text editor. Right click it and from the TSVN menu choose the Revert command. (tsvn1.png)

Two dialog boxes will be displayed. To reproduce the problem you must click the OK of the second window FAST (as soon as possible). Explorer window will be displayed without overlay icons. (tsvn2.png)

After a few second is Explorer refreshed. (tsvn3.png)

Could somebody please test this scenario on your Windows? The phase without overlay icons looks very suspicious to me.

cincura.net · Post by **cincura.net** » 08 Aug 2008, 17:48

Jan Rysavy wrote:Could somebody please test this scenario on your Windows? The phase without overlay icons looks very suspicious to me.

AFAIK this is expected.

Post by **Jan Rysavy** » 08 Aug 2008, 19:23

cincura.net wrote:AFAIK this is expected.

Could you post more details? Why doesn't TSVN return overlay icons for the first time?

cincura.net · Post by **cincura.net** » 08 Aug 2008, 20:59

Jan Rysavy wrote:Could you post more details? Why doesn't TSVN return overlay icons for the first time?

When you do some change in folder. Then the icons needs to be refreshed. During this small amount of time, you can experience that no icons are shown. It's probably (just shoot) related to cache changes.

In some help/doc/... I've read about this (same as i.e. you see wrong icons 'cause of cache refresh delay).

BTW you can try to change cache settings (not use TSVNCache and use Shell) and try to test this. It should work "normal".

Post by **Jan Rysavy** » 09 Aug 2008, 05:31

I don't get it. The TSVN did the Revert command. Why should they need several seconds to realize it? Furthermore, the overlay icon handler should not return value until they know it to avoid the "no overlay" phase.

Still seems like shortcoming in overlay icon handler implementation from the user experience point of view.

cincura.net · Post by **cincura.net** » 10 Aug 2008, 14:33

Jan Rysavy wrote:I don't get it. The TSVN did the Revert command. Why should they need several seconds to realize it? Furthermore, the overlay icon handler should not return value until they know it to avoid the "no overlay" phase.

It's probably some implementation stuff. I didn't looked to sources. I know this from my experience (and some docs on internet).

Jan Rysavy wrote:Still seems like shortcoming in overlay icon handler implementation from the user experience point of view.

Yep.

Post by **Petr Solin** » 22 Aug 2008, 16:04

We have just implemented catching of Tortoise SVN notifications regarding changed icon-overlays, so TSVN icon-overlays are refreshed even if there are no disk-changes in displayed directory in panel. It also solves the problem with fast return to Salamander's window after Revert command which is discussed in this thread).

Moreover we have enabled auto-refreshes also in inactive window of Salamander, so you will always see current content of displayed directories (now it's displayed only after activation of Salamander's main window).