Page 1 of 1

Open Salamander: Czech to English comments translation

Posted: 04 Dec 2023, 13:46
by -=Majkl=-
I can translate Czech comments in code, if it helps for further development. What files have the highest priority, where can I start?

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 16:53
by Jan Rysavy
It would be great!

The core of the Salamander is located in the '\src' directory, which includes files like bitmap.cpp, bitmap.h, and so on.
https://github.com/OpenSalamander/salam ... e/main/src

I would use Visual Studio Code or Visual Studio (Community Edition) for such work, both have spell checker and GitHub Copilot integration.

It would be good to start small steps at a time to catch any bugs right at the beginning.

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 18:19
by -=Majkl=-
Jan Rysavy wrote: 04 Dec 2023, 16:53 It would be great!

The core of the Salamander is located in the '\src' directory, which includes files like bitmap.cpp, bitmap.h, and so on.
https://github.com/OpenSalamander/salam ... e/main/src

I would use Visual Studio Code or Visual Studio (Community Edition) for such work, both have spell checker and GitHub Copilot integration.

It would be good to start small steps at a time to catch any bugs right at the beginning.
I just tried it. I've included .gitignore file by mistake as well, and I did not know how to remove it from the Pull request.

It's my first attempt to put something to GitHub from Visual Studio, sorry for the mess, it is going to be better next time! :)

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 21:17
by Jan Rysavy
That looks great! I just tried out ChatGPT 4, maybe it could make things a bit easier?
I have small python script to extract comments from source file.

https://chat.openai.com/share/f52583f6- ... 803e1fd192

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 21:39
by -=Majkl=-
I was a bit worried about the missing diacritics in the source (Czech) strings, but it looks like AI understood the meaning. The most critical differences are in the used terminology. I've used "fetch" for "vytáhnu" (which does not sound technical at all :D), while AI used "extract", etc.

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 21:42
by Jan Rysavy
Another option, GitHub Copilot with Visual Studio 2022:
1.png
1.png (103.08 KiB) Viewed 47985 times
2.png
2.png (264.5 KiB) Viewed 47985 times

Re: Unicode version (early preview)

Posted: 04 Dec 2023, 22:15
by Jan Rysavy
Another idea: it is possible to create a GitHub pull request directly from VS2022:

https://devblogs.microsoft.com/visualst ... al-studio/

https://learn.microsoft.com/en-us/visua ... ew=vs-2022

Re: Open Salamander: Czech to English comments translation

Posted: 09 Dec 2023, 17:21
by ladis
Just a minor nitpick before more people jump in: it is often important to setup coding rules and commit message rules first. Such commits as „Update README” are a bit hard to understand without actually looking at the diff. Similarly „English translation of source code comments for bitmap.cpp” could be written as „bitmap.cpp: translate comments”.

Re: Open Salamander: Czech to English comments translation

Posted: 11 Dec 2023, 06:04
by Jan Rysavy
ladis wrote: 09 Dec 2023, 17:21 Just a minor nitpick before more people jump in: it is often important to setup coding rules and commit message rules first. Such commits as „Update README” are a bit hard to understand without actually looking at the diff. Similarly „English translation of source code comments for bitmap.cpp” could be written as „bitmap.cpp: translate comments”.
I agree, I will use better commit messages for further changes.

Re: Open Salamander: Czech to English comments translation

Posted: 11 Dec 2023, 07:02
by SelfMan
Small suggestion for the team - set the rules and decide who will do the "spell check" so that the rules are uphold.