Bug: submission order of multi-file selection

Discussion of bugs and problems found in Altap Salamander. In your reports, please be as descriptive as possible, and report one incident per report. Do not post crash reports here, send us the generated bug report by email instead, please.
roman2
Posts: 106
Joined: 07 Aug 2006, 11:11

Bug: submission order of multi-file selection

Post by roman2 » 03 Feb 2009, 13:01

I selected several mp3 files in Salamander, right-clicked on one of them, and selected Play in Winamp. The files got inserted into Winamp's play list; however, the first file in the play list happened to be the one I clicked on in Salamander, which was out of desired order. The selection should be acted upon regardless which element (file or directory) is clicked on.

Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5135
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Post by Jan Rysavy » 03 Feb 2009, 13:35

This new behavior is fix of old bug. The focused file is given as first. Try Windows Explorer, it behaves the same way.

I just discovered we didn't fix the problem properly in AS 2.52 beta 1.

When you select 4 files and open context menu with focus on file 3:
1 (selected)
2 (selected)
3 (selected & focused)
4 (selected)

you will get following order in WinAMP:
AS 2.51: 1, 2, 3, 4
AS 2.52b1: 3, 1, 2, 4
Explorer: 3, 4, 1, 2

We will fix this problem in AS 2.52b2.

Btw, the Foobar2000 v0.9.6.2 is handling this situation the same way as you are expecting. Always in order 1, 2, 3, 4. It doesn't matter which file is focused. Great player.

roman2
Posts: 106
Joined: 07 Aug 2006, 11:11

Post by roman2 » 03 Feb 2009, 18:24

Yes, Explorer does it the way as you described it, but is there a good reason for doing it this way?

User avatar
SelfMan
Posts: 928
Joined: 05 Apr 2006, 20:51
Contact:

Post by SelfMan » 03 Feb 2009, 23:58

I prefere the "old" 1,2,3,4 way.
+1 from me

roman2
Posts: 106
Joined: 07 Aug 2006, 11:11

Post by roman2 » 04 Feb 2009, 04:45

Maybe if a gun were put to my head, I'd come up with a use case for the Explorer's way of doing this, but I don't think I've needed this so far.

User avatar
ino
Posts: 440
Joined: 09 Dec 2005, 14:59
Location: Brno, Czech Republic

Post by ino » 04 Feb 2009, 07:31

SelfMan wrote:I prefere the "old" 1,2,3,4 way.
+1 from me
I thing AS should not copy all "strange" behaviour from MSExplorer.
+1

Petr Solin
ALTAP Staff
ALTAP Staff
Posts: 1105
Joined: 08 Dec 2005, 09:13
Location: Novy Bor, Czech Republic
Contact:

Post by Petr Solin » 04 Feb 2009, 21:07

All context menu handlers are designed for Explorer, so we try to make Salamander's behavior the same because every little difference can lead to unexpected things.

If you don't like this Winamp behavior, try to report it, they may fix this because it is problem of whole Winamp community.

Ondra Ch.
Posts: 6
Joined: 12 Feb 2009, 11:24

Post by Ondra Ch. » 12 Feb 2009, 13:14

ino wrote:
SelfMan wrote:I prefere the "old" 1,2,3,4 way.
+1 from me
I thing AS should not copy all "strange" behaviour from MSExplorer.
+1
+1 from me.

This is not related to WinAmp from my point of view - I am having the same issue with Win Media Player. Generally, anytime I select a buch of files to do some action, I really mean to have it done on the files in the order they are showing in the panel, not from the focused one.

Changing it to 3, 4, 1, 2 sounds even less useful for me. Well, maybe because I never used Explorer, but Salamander all the time :-)

Please make the Explorer-like behavior at most optional, not the only one possible for everybody.

Thanks,
Ondřej

User avatar
Raptor
Posts: 706
Joined: 28 Jan 2006, 15:04
Location: Prague, Czech Republic
Contact:

Post by Raptor » 12 Feb 2009, 13:28

SelfMan wrote:I prefere the "old" 1,2,3,4 way.
+1 from me
+1

User avatar
SelfMan
Posts: 928
Joined: 05 Apr 2006, 20:51
Contact:

Post by SelfMan » 12 Feb 2009, 13:59

Jan Rysavy wrote:When you select 4 files and open context menu with focus on file 3:
1 (selected)
2 (selected)
3 (selected & focused)
4 (selected)

you will get following order in WinAMP:
AS 2.51: 1, 2, 3, 4
AS 2.52b1: 3, 1, 2, 4
Explorer: 3, 4, 1, 2
I've just checked the behavior and get the 3,4,1,2 in AS2.52b1 (2.5.2.18) and WinAMP 2.91 (I know... a OOOLLLD version, but not that bloated and working...)

Petr Solin
ALTAP Staff
ALTAP Staff
Posts: 1105
Joined: 08 Dec 2005, 09:13
Location: Novy Bor, Czech Republic
Contact:

Post by Petr Solin » 12 Feb 2009, 14:19

SelfMan wrote:I've just checked the behavior and get the 3,4,1,2 in AS2.52b1 (2.5.2.18)
You probably have patched version (not original salamand.exe from installation).

Well, we have decided to change it back to original behaviour (independent on focus position): 1,2,3,4. :) It will be in 2.52 beta 2.

Ondra Ch.
Posts: 6
Joined: 12 Feb 2009, 11:24

Post by Ondra Ch. » 12 Feb 2009, 14:24

Petr Solin wrote:Well, we have decided to change it back to original behaviour (independent on focus position): 1,2,3,4. :) It will be in 2.52 beta 2.
Excellent, thanks a lot 8)

Ondřej

User avatar
SelfMan
Posts: 928
Joined: 05 Apr 2006, 20:51
Contact:

Post by SelfMan » 12 Feb 2009, 14:40

Petr Solin wrote:Well, we have decided to change it back to original behaviour (independent on focus position): 1,2,3,4. :) It will be in 2.52 beta 2.
I am not gay but I love you guys! :-) +∞

pjj

Post by pjj » 14 Feb 2009, 14:27

Petr Solin wrote:Well, we have decided to change it back to original behaviour (independent on focus position): 1,2,3,4. :) It will be in 2.52 beta 2.
This is great news, since I really detest this new behaviour. Thanks a lot!

Post Reply