Open Salamander: Czech to English comments translation

This is a place for users to discuss Altap Salamander. Please feel free to ask, answer questions, and express your opinion. Please do not post problems, bug reports or feature requests here.
-=Majkl=-
Posts: 80
Joined: 12 Dec 2005, 14:51
Location: Brno, Czech Republic
Contact:

Open Salamander: Czech to English comments translation

Post by -=Majkl=- »

I can translate Czech comments in code, if it helps for further development. What files have the highest priority, where can I start?
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by Jan Rysavy »

It would be great!

The core of the Salamander is located in the '\src' directory, which includes files like bitmap.cpp, bitmap.h, and so on.
https://github.com/OpenSalamander/salam ... e/main/src

I would use Visual Studio Code or Visual Studio (Community Edition) for such work, both have spell checker and GitHub Copilot integration.

It would be good to start small steps at a time to catch any bugs right at the beginning.
-=Majkl=-
Posts: 80
Joined: 12 Dec 2005, 14:51
Location: Brno, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by -=Majkl=- »

Jan Rysavy wrote: 04 Dec 2023, 16:53 It would be great!

The core of the Salamander is located in the '\src' directory, which includes files like bitmap.cpp, bitmap.h, and so on.
https://github.com/OpenSalamander/salam ... e/main/src

I would use Visual Studio Code or Visual Studio (Community Edition) for such work, both have spell checker and GitHub Copilot integration.

It would be good to start small steps at a time to catch any bugs right at the beginning.
I just tried it. I've included .gitignore file by mistake as well, and I did not know how to remove it from the Pull request.

It's my first attempt to put something to GitHub from Visual Studio, sorry for the mess, it is going to be better next time! :)
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by Jan Rysavy »

That looks great! I just tried out ChatGPT 4, maybe it could make things a bit easier?
I have small python script to extract comments from source file.

https://chat.openai.com/share/f52583f6- ... 803e1fd192
-=Majkl=-
Posts: 80
Joined: 12 Dec 2005, 14:51
Location: Brno, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by -=Majkl=- »

I was a bit worried about the missing diacritics in the source (Czech) strings, but it looks like AI understood the meaning. The most critical differences are in the used terminology. I've used "fetch" for "vytáhnu" (which does not sound technical at all :D), while AI used "extract", etc.
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by Jan Rysavy »

Another option, GitHub Copilot with Visual Studio 2022:
1.png
1.png (103.08 KiB) Viewed 47572 times
2.png
2.png (264.5 KiB) Viewed 47572 times
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: Unicode version (early preview)

Post by Jan Rysavy »

Another idea: it is possible to create a GitHub pull request directly from VS2022:

https://devblogs.microsoft.com/visualst ... al-studio/

https://learn.microsoft.com/en-us/visua ... ew=vs-2022
ladis
Posts: 4
Joined: 22 Aug 2015, 00:36

Re: Open Salamander: Czech to English comments translation

Post by ladis »

Just a minor nitpick before more people jump in: it is often important to setup coding rules and commit message rules first. Such commits as „Update README” are a bit hard to understand without actually looking at the diff. Similarly „English translation of source code comments for bitmap.cpp” could be written as „bitmap.cpp: translate comments”.
Jan Rysavy
ALTAP Staff
ALTAP Staff
Posts: 5231
Joined: 08 Dec 2005, 06:34
Location: Novy Bor, Czech Republic
Contact:

Re: Open Salamander: Czech to English comments translation

Post by Jan Rysavy »

ladis wrote: 09 Dec 2023, 17:21 Just a minor nitpick before more people jump in: it is often important to setup coding rules and commit message rules first. Such commits as „Update README” are a bit hard to understand without actually looking at the diff. Similarly „English translation of source code comments for bitmap.cpp” could be written as „bitmap.cpp: translate comments”.
I agree, I will use better commit messages for further changes.
User avatar
SelfMan
Posts: 1144
Joined: 05 Apr 2006, 20:51
Contact:

Re: Open Salamander: Czech to English comments translation

Post by SelfMan »

Small suggestion for the team - set the rules and decide who will do the "spell check" so that the rules are uphold.
Post Reply