Wrong displayed file size in bz2 archive

Discussion of bugs and problems found in Altap Salamander. In your reports, please be as descriptive as possible, and report one incident per report. Do not post crash reports here, send us the generated bug report by email instead, please.
User avatar
crystalidea
Posts: 204
Joined: 09 Dec 2005, 15:13
Contact:

Wrong displayed file size in bz2 archive

Post by crystalidea »

The size of the file inside this archive is not 0!
http://prdownloads.sf.net/mingw/MSYS-1. ... 2?download
Tomas Kopal
ALTAP Staff
ALTAP Staff
Posts: 131
Joined: 07 Dec 2005, 23:01
Location: Prague, Czech Republic
Contact:

Re: BUG: bz2

Post by Tomas Kopal »

XPiS wrote:The size of the file inside this archive is not 0!
http://prdownloads.sf.net/mingw/MSYS-1. ... 2?download
Well, trouble with bzip2 archives is that they do not store the uncompressed size of the file in the archive. So we basically have two options, either display zero (that's what we do right now) or decompress the whole archive just to determine it's size, which could take ages for large archives.
We plan to "improve" this situation by not displaying the size at all for such archives, but it's low priority at the moment.
-=Majkl=-
Posts: 73
Joined: 12 Dec 2005, 14:51
Location: Brno, Czech Republic
Contact:

Post by -=Majkl=- »

could it work in this way:

- first, archive is opened, zero sizes are shown
- while browsing the archive, the sizes of files are being showed - this should be proccessed in other (low priority) thread
Tomas Kopal
ALTAP Staff
ALTAP Staff
Posts: 131
Joined: 07 Dec 2005, 23:01
Location: Prague, Czech Republic
Contact:

Post by Tomas Kopal »

-=Majkl=- wrote:could it work in this way:

- first, archive is opened, zero sizes are shown
- while browsing the archive, the sizes of files are being showed - this should be proccessed in other (low priority) thread
Well, bz2 archive can contain only one file, so "browsing" is probably not the best description :-).
I was considering the option to uncompress the archive in a separate thread as well, but I think the complexity of such workaround is not worth the benefit. Also, the interface Salamander offers to archiver plugins does not allow to alter the information "later", after initial listing was done, so the work to implement this would be really considerable (read: not worth it).
User avatar
SvA
Posts: 468
Joined: 29 Mar 2006, 02:41
Location: DE

Post by SvA »

Tomas Kopal wrote:Also, the interface Salamander offers to archiver plugins does not allow to alter the information "later", after initial listing was done, so the work to implement this would be really considerable (read: not worth it).
Do you distiguish between archiver plugins and file system plugins? If you don't, you should ernestly consider adding an update feature (push update or a callback) to the interface. Many possible plugins could benefit from it.
Tomas Kopal
ALTAP Staff
ALTAP Staff
Posts: 131
Joined: 07 Dec 2005, 23:01
Location: Prague, Czech Republic
Contact:

Post by Tomas Kopal »

SvA wrote:Do you distiguish between archiver plugins and file system plugins?
Yes, we do. Writing filesystem plugins is considerably more complex (but the interface is also more powerful) than archiver plugins, so they are used only if the benefit is worth it.
Post Reply